Skip to content

Local test followup #24884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Apr 25, 2025

Fix issues uncovered in the tests after local test runs with the installation of test packages:

  • LinuxHelper: fix a regression from JDK-8354988. Before the JDK-8354988 fix, when a process started with Executor didn't write to stdout, Executor.executeAndGetFirstLineOfOutput() returned an empty string; after the fix, it throws an exception.
  • Fix EmptyFolderTest: when an MSI is installed, it can create empty directories. Empty directories are not created only when it is unpacked. We probably never ran EmptyFolderTest in "install test packages" mode; we always executed it in "unpack test packages" mode.
  • Fix PackageTest.Group to make it work correctly when a test runs jpackage to produce both exe and msi packages, and when they are installed.

Before the fix, the sequence was:

for (action in {create, install, uninstall}) {
  for (test in tests) {
    for (type in {exe, msi}) {
      run $action on $test of $type
    }
  }
}

After the fix, the sequence is:

for (type in {exe, msi}) {
  for (action in {create, install, uninstall}) {
    for (test in tests) {
      run $action on $test of $type
    }
  }
}

Additionally:

  • Add missing @Test annotation in PathGroupTest;
  • Fix typo in PListReaderTest: STRING_ARRY -> STRING_ARRAY;
  • Optimize RuntimeImageTest to not run jlink if external Java runtime is supplied;
  • Add a test to RuntimeImageTest to verify jpackage strips the "jmod" directory and the "src.zip" file from an external runtime image

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24884/head:pull/24884
$ git checkout pull/24884

Update a local copy of the PR:
$ git checkout pull/24884
$ git pull https://git.openjdk.org/jdk.git pull/24884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24884

View PR using the GUI difftool:
$ git pr show -t 24884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24884.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant