-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Local test followup #24884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Local test followup #24884
Conversation
… enabled and when PackageTest.Group is used
….zip files are stripped from copied runtime
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Fix issues uncovered in the tests after local test runs with the installation of test packages:
Executor.executeAndGetFirstLineOfOutput()
returned an empty string; after the fix, it throws an exception.PackageTest.Group
to make it work correctly when a test runs jpackage to produce both exe and msi packages, and when they are installed.Before the fix, the sequence was:
After the fix, the sequence is:
Additionally:
@Test
annotation in PathGroupTest;Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24884/head:pull/24884
$ git checkout pull/24884
Update a local copy of the PR:
$ git checkout pull/24884
$ git pull https://git.openjdk.org/jdk.git pull/24884/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24884
View PR using the GUI difftool:
$ git pr show -t 24884
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24884.diff