Skip to content

8355608: Async UL should take the file lock of stream when outputting #24874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Apr 25, 2025

With the introduction of JDK-8349755, it is not entirely clear any longer that the Async UL has exclusive access to the files which are being logged to in the JVM. We should take the file lock for the stream being logged to for safety's sake.

If, for example, an unattached thread logs, then it will do so without the help of the Async UL thread.

This is expected to very rarely, if ever, happen. Since taking an uncontested mutex is very cheap, I expect this to have a negligible performance impact.

Testing: GHA, tier1

Cheers,
Johan


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355608: Async UL should take the file lock of stream when outputting (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24874/head:pull/24874
$ git checkout pull/24874

Update a local copy of the PR:
$ git checkout pull/24874
$ git pull https://git.openjdk.org/jdk.git pull/24874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24874

View PR using the GUI difftool:
$ git pr show -t 24874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24874.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8355608 8355608: Async UL should take the file lock of stream when outputting Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jdksjolen jdksjolen marked this pull request as ready for review April 25, 2025 13:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant