Skip to content

8355577: Remove old sparc remnants in the hotspot linux code #24873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 25, 2025

Linux SPARC support is long gone, but there are a few remnants of SPARC support in hotspot Linux coding. Remove them where it is beneficial to clean up.

I kept sparc in the shared lib handling code because this runs on other platforms too.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355577: Remove old sparc remnants in the hotspot linux code (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24873/head:pull/24873
$ git checkout pull/24873

Update a local copy of the PR:
$ git checkout pull/24873
$ git pull https://git.openjdk.org/jdk.git pull/24873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24873

View PR using the GUI difftool:
$ git pr show -t 24873

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24873.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8355577: Remove old sparc remnants in the hotspot linux code 8355577: Remove old sparc remnants in the hotspot linux code Apr 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 25, 2025

Webrevs

@zhengyu123
Copy link
Contributor

arch_array also contains SPARC specific definition, e.g. https://github.com./openjdk/jdk/blob/master/src/hotspot/os/linux/os_linux.cpp#L1754, you might want to remove them as well.

@ptribble
Copy link
Contributor

ptribble commented Apr 26, 2025

Would any of this code be used by zero? I know Debian ship the zero jdk on sparc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants