Type checking improvements #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
reviewed
Apr 15, 2020
| @@ -236,14 +236,16 @@ def _iterate_properties() -> Generator[Property, None, None]: | |||
|
|
|||
| @staticmethod | |||
| def from_dict(d: Dict[str, Dict[str, Any]], /) -> OpenAPI: | |||
| """ Create an OpenAPI from dict """ | |||
| """ Create an OpenAPI from dict | |||
| :rtype: object | |||
There was a problem hiding this comment.
Why is this necessary? Does mypy have a problem with -> OpenAPI for some reason?
| schemas = Schema.dict(d["components"]["schemas"]) | ||
| endpoint_collections_by_tag = EndpointCollection.from_dict(d["paths"]) | ||
| enums = OpenAPI._check_enums(schemas.values(), endpoint_collections_by_tag.values()) | ||
|
|
||
| return OpenAPI( | ||
| title=d["info"]["title"], | ||
| description=d["info"]["description"], | ||
| description=d["info"].get("description"), |
There was a problem hiding this comment.
This is to allow description to be empty right? So then we'd need to make OpenAPI.description an Optiona[str] instead of a str to be correct.
dbanty
added a commit
that referenced
this pull request
Apr 25, 2020
dbanty
added a commit
that referenced
this pull request
Apr 25, 2020
|
I went ahead and make the couple of changes I'd asked for and completed this with #35. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to eliminate mypy errors from the output