Handle Unset Enums when deserializing

[bowenwr]

When an Enum is Unset during deserialization, it causes an error by attempting to instantiate it from UNSET.

[codecov]

Codecov Report

Merging #306 (f1b3e4e) into main (abf906d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #306   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1385      1385           
=========================================
  Hits          1385      1385           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf906d...f1b3e4e. Read the comment docs.

[bowenwr]

CC @dbanty. Good chance we have this issue other places as well but Enums were the ones ruining my day. 😬

[emann]

LGTM! Thanks as always @bowenwr 😄

Unrelated, but this makes me think that maybe we should look into hypothesis - I've never used it personally, but I think it would help us in covering edge cases like this that slip by unnoticed.

[bowenwr]

Thanks for a speedy review @emann (didn't there used to be a guitar in there?)! I don't have personal experience with hypothesis, but agree that property-based testing might help us catch a lot more.

[emann]

@bowenwr There was a guitar in there until I managed to steal @emann - it had been taken but inactive for 9 years and github gave it to me!

I also have no personal experience with hypothesis haha - I do think it could be useful here though, so I may look into it in the near future.

[bowenwr]

Thanks @emann! Anything blocking this from a merge?

[emann]

@bowenwr nope, sorry! I've enabled auto-merge, if you could add a changelog entry and pull in the latest changes from main that'd be swell and it should merge automatically

[bowenwr]

@emann Done, thank you!