Add support for date format in string types
#30
Conversation
There was a problem hiding this comment.
Thanks for the addition! There are a couple things not covered by unit tests like the error when a string format is not recognized and the transform functions on DateTimeProperty and DateProperty.
I think I managed to turn on CircleCI builds for forked pull requests? We'll see. If not you can run pytest --cov=openapi_python_client and then coverage to see what is and isn't covered.
I'd also like to cover each new feature going forward in the end to end tests by declaring something that tests it in the FastAPI app and regenerating openapi.json and the golden master. This is the only way templates are really tested today. If you can't easily get that working it's fine, I can do it after I merge in.
| if isinstance(prop, DateProperty): | ||
| self.relative_imports.add("from datetime import date") | ||
| if isinstance(prop, DateTimeProperty): | ||
| self.relative_imports.add("from datetime import datetime") |
There was a problem hiding this comment.
I actually always import datetime in templates/model.pyi right now but only importing when needed seems better. Will you remove it from that template?
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 532 572 +40
=========================================
+ Hits 532 572 +40
Continue to review full report at Codecov.
|
Add support for
datefield format alongsidedate-time