Lower version requirements for python-dateutil in generated client #298 #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1348 1348
=========================================
Hits 1348 1348 Continue to review full report at Codecov.
|
|
@dbanty I changed it in the templates for the generated client but not in the root |
|
FYI @packyg |
dbanty
requested changes
Jan 14, 2021
Co-authored-by: Dylan Anthony <[email protected]>
dbanty
approved these changes
Jan 14, 2021
|
Looks great, I love a nice easy code review in the morning |
Thanks for your help and being so obliging! 🙌 |
dbanty
added a commit
that referenced
this pull request
Jan 16, 2021
bowenwr
added a commit
to benchling/openapi-python-client
that referenced
this pull request
Jan 20, 2021
openapi-generators#298 (openapi-generators#299) * Lower version requirements for python-dateutil in generated client openapi-generators#298 * Update CHANGELOG.md Co-authored-by: Dylan Anthony <[email protected]> Co-authored-by: Dylan Anthony <[email protected]>
bowenwr
added a commit
to benchling/openapi-python-client
that referenced
this pull request
Jan 28, 2021
openapi-generators#298 (openapi-generators#299) * Lower version requirements for python-dateutil in generated client openapi-generators#298 * Update CHANGELOG.md Co-authored-by: Dylan Anthony <[email protected]> Co-authored-by: Dylan Anthony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated client now features a slightly more permissive version of
python-dateutilto reduce dependency conflicts with some other projects. #298