Bugfix: Implement __str__ for enum props to fix query string #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update both string and int enums to have a
__str__
method that return just the string representation of the value:This fixes a bug introduced in #241 (my bad 😬 ). As I noted on that PR, request bodies will be fine as
json.dumps
will convert the enums correctly. However it does not work for query string params -urllib.parse.urlencode
(whichhttpx
uses here)just does
str(val)
, which returns"EnumClass.key"
.So
would result in a query string of
?someQueryString=SomeEnum.val
instead of?someQueryString=a_value