-
-
Notifications
You must be signed in to change notification settings - Fork 596
[0.x] Adds Moderations::create
typed response
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.x] Adds Moderations::create
typed response
#5
Conversation
@gehrisandro It's possible to focus this pull request in only on typed responses, and on a single resource method (Moderations::create)? So we can define their structure together, and have a good foundation for the remaining methods. |
Moderations::create
typed response
0f7458b
to
a4c02b1
Compare
@nunomaduro I narrowed the pull request down to focus only on the typed response as you suggested. In my opinion the typed response is very easy to understand and use.
I'm looking forward to hearing your opinion. |
@gehrisandro Left a few comments - regarding the way I would probably structure this. |
Thank you for our feedback. I renamed classes / namespaces in the way to suggested, updated and cleaned update the tests. |
Adjusting things locally. |
Added startChat method to ChatSessionContract
There we go.
see #4