Add custom client earlier in README #486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this it's opaque that the library is making HTTP requests, or to where it might be making them. The only place I could find how to change the localhost:11434 behavior was in the Ollama FAQs. If there is a way to set it besides OLLAMA_HOST I would love to know!
|
|
byarbrough
changed the title
|
I'm okay with the callout to I'd rather not add the host callouts in here as they are more Ollama related and not directly the library. I think it would be better to add a link to https://github.com./ollama/ollama/blob/main/docs/faq.md instead. |
ParthSareen
reviewed
Apr 22, 2025
Comment on lines
+12
to
+13
| You can change this address with the [custom client](https://github.com./ollama/ollama-python?tab=readme-ov-file#custom-client) | ||
| or by setting the [`OLLAMA_HOST`](https://github.com./ollama/ollama/blob/main/docs/faq.md#how-can-i-expose-ollama-on-my-network) environment variable. |
There was a problem hiding this comment.
Suggested change
| You can change this address with the [custom client](https://github.com./ollama/ollama-python?tab=readme-ov-file#custom-client) | |
| or by setting the [`OLLAMA_HOST`](https://github.com./ollama/ollama/blob/main/docs/faq.md#how-can-i-expose-ollama-on-my-network) environment variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this it's not immediately apparent that the library is making HTTP requests, or to where it might be making them.