-
-
Notifications
You must be signed in to change notification settings - Fork 618
feat: add api.fs.copy.basename, default mapping ge #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add api.fs.copy.basename, default mapping ge #2698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be really handy. Works as expected.
We do need to change the mapping:
- users expect
l
to act as per default vim behaviour
Our copy mappings aren't great:
I'm using
Unfortunately we can't change the defaults. |
Nice mappings. I think I'll use them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working, just needs style and help fixes.
First time contributors don't get automated CI ;)
I believe it is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all your work!
Hi there 👋
I would like to propose a new keymap, which is copying basename of a file. I believe in most OOP and functional programming language it is very common to create a file for a class/function and name the file and the class/function the same, so the process goes like creating a
somelongNameThatIDontWantToTypeAgain.js
file and then wanting to create a function with the same name. Currently I usey
and then manually delete the extension. I personally dont think I have ever used they
as it is and only to copy and then delete the extension.I hope you can see the value in having such a keymap. The mapping
l
was random. I just used what is still available and can change it to whatever you like.Hope you find it useful too. I think it'll impact lots of users.