fix(#2954): more efficient LSP updates, increase diagnostics.debounce_delay from 50ms to 500ms #3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Nov 18, 2024
| @@ -135,35 +108,77 @@ local function from_cache(node) | |||
| for bufname, severity in pairs(NODE_SEVERITIES) do | |||
| local node_contains_buf = vim.startswith(bufname, nodepath .. "/") | |||
| if node_contains_buf then | |||
| if severity == M.severity.max then | |||
| if not max_severity or severity < max_severity then | |||
There was a problem hiding this comment.
This became a warning hence it was simplified.
alex-courtis
commented
Nov 18, 2024
| @@ -17,7 +17,7 @@ local COC_SEVERITY_LEVELS = { | |||
| } | |||
|
|
|||
| ---Absolute Node path to LSP severity level | |||
| ---@alias NodeSeverities table<string, lsp.DiagnosticSeverity> | |||
| ---@alias NodeSeverities table<string, vim.diagnostic.Severity> | |||
There was a problem hiding this comment.
lsp.DiagnosticSeverity and vim.diagnostic.Severity are effectively the same. It's not clear which is preferred, so I went with the one from vim.Diagnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2954
@des-b I'd be most grateful for your review and thoughts.
This changes the approach to LSP:
DiagnosticChangeddata on the event (sync) threadNODE_SEVERITIESandNODE_SEVERITIES_VERSIONonly updated on deltaThe debounce delay was increased as there are a lot of events as the user types.
It's not clear whether a full redraw
Ris needed; it could clearNODE_SEVERITIESand rebuild it. YAGNI?