Use index rather than telldir
/seekdir
to represent fd_readdir
cookie
#298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/node#47193
How
telldir
andseekdir
work depends on the operating system. For example, in ubuntu,telldir
returns a relative pos of current dirent iterator. But in macos,telldir
returns a self-incrementing counter, which is only valid for oneDIR*
.The issue is that every single call to
fd_readdir
opens and closes the dir, so the cookie becomes invalid on the next call, thus getting infinite loop.