[v22.x] Backport "module: fix strip-types interaction with detect-module" #54211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
marco-ippolito
added
needs-ci
Merged
marco-ippolito
added
lib / src
github-actions
bot
removed
the
request-ci
khaosdoctor
approved these changes
Aug 5, 2024
joyeecheung
approved these changes
Aug 5, 2024
RafaelGSS
force-pushed
the
v22.x-staging
branch
from
9b20410 to
b731528
Compare
PR-URL: nodejs#54164 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito
force-pushed
the
backport/strip-types-imply
branch
from
23d5d60 to
01631f3
Compare
RafaelGSS
approved these changes
Aug 5, 2024
marco-ippolito
added a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54164 Backport-PR-URL: #54211 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in c20e841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #54164
This backport adds the imply of
--experimental-detect-moduleto--experimental-strip-typeshttps://github.com./nodejs/node/pull/54211/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8R803
cc @joyeecheung