Skip to content

module: fix resolution consistency between '.' and './' #47019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pouwerkerk
Copy link

Fixes: #47000

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@dario-piotrowicz
Copy link
Member

#47000 got fixed by #56735 so this PR can be closed now

@ljharb ljharb closed this Jan 26, 2025
@pouwerkerk pouwerkerk deleted the require-resolve-relative-path-fix branch January 26, 2025 16:53
@dario-piotrowicz
Copy link
Member

@pouwerkerk I noticed your frowning/confused reaction to my comment above, I did noticed your PR when solving the issue but since it hadn't been worked on for a long while I was pretty sure you lost interest in this, sorry I should have asked you if we wanted to finish this 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: require.resolve(".", { paths }) behaves differently from require.resolve("./", { paths })
4 participants