[12.x backport] module: package "exports" error refinements #32287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
4 tasks
codebytere
force-pushed
the
v12.x-staging
branch
from
2047cca to
0606e1d
Compare
guybedford
force-pushed
the
12-module-refinements
branch
from
f577233 to
1e36c5a
Compare
GeoffreyBooth
approved these changes
Mar 23, 2020
codebytere
force-pushed
the
v12.x-staging
branch
from
a01fb4a to
e5dc2fb
Compare
guybedford
force-pushed
the
12-module-refinements
branch
from
1e36c5a to
7dd15fd
Compare
codebytere
force-pushed
the
v12.x-staging
branch
2 times, most recently
from
63a03d2 to
d577190
Compare
|
@guybedford staging should be good to rebase against, then we can get this landed. |
PR-URL: nodejs#31625 Reviewed-By: Jan Krems <[email protected]>
guybedford
force-pushed
the
12-module-refinements
branch
from
7dd15fd to
03a28dd
Compare
|
Thanks @codebytere for the ping, I've done a fresh rebase. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
this lands cleanly on v12.x-staging without needing backport. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the PR from #31625.
//cc @codebytere
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes