build: more portable Makefile #28108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make some `$(shell)` calls lazy * `$(wildcard)` instead of `ls` * `$(info)` instead of `echo` * `$?` instead of duplicated file lists
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
build
|
Assuming it passes ci ... :-) |
This was referenced Jun 6, 2019
2 tasks
richardlau
reviewed
Jun 13, 2019
| @$(call available-node,$(run-lint-doc-md)) | ||
| @touch $@ | ||
| tools/.docmdlintstamp: AVALIBLE_NODE := $(available-node-shell) | ||
| tools/.docmdlintstamp: $(wildcard doc/*.md doc/**/*.md) |
There was a problem hiding this comment.
doc/**/*.md doesn't appear to pick up all subdirectories under doc with wildcard.
There was a problem hiding this comment.
5 mins of searching, and I couldn't even find a definition of what pattern means for wildcard() in GNU make, much less generally. I didn't think ** was supported unless the shell supported it, and I just tried on AIX, which is agressively POSIX, and it didn't expand.
|
@refack this needs a rebase |
|
Closing, since there was no follow up for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(shell)calls lazy$(wildcard)instead ofls$(info)instead ofecho$?instead of duplicated file listsBiggest benefit: smoother experience with MSYS
make(can be added to "Git Bash", or vendored)/CC @nodejs/build-files @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes