Skip to content

tools: strange workaround in doctools #20685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt opened this issue May 12, 2018 · 0 comments
Closed

tools: strange workaround in doctools #20685

vsemozhetbyt opened this issue May 12, 2018 · 0 comments
Labels
doc Issues and PRs related to the documentations. question Issues that look for answers. tools Issues and PRs related to the tools directory.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 12, 2018

  1. tools/doc/package.json requires "js-yaml": "^3.5.2":

"js-yaml": "^3.5.2"

  1. tools/doc/node_modules/js-yaml contains only dummy index.js with reexport of js-yaml from ESLint dependency (so the version from the above-mentioned requirement cannot be checked anyway?):

const realJSYaml = path.resolve(
__dirname, '..', '..', '..', // tools/
'node_modules',
'eslint',
'node_modules',
'js-yaml'
);

Why not delete js-yaml from tools/doc/package.json, then delete tools/doc/node_modules/js-yaml and then require js-yaml straight from the ESLint dependency? It is only required here:

const yaml = require('js-yaml');

@vsemozhetbyt vsemozhetbyt added question Issues that look for answers. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels May 12, 2018
MylesBorins pushed a commit that referenced this issue May 22, 2018
PR-URL: #20701
Fixes: #20685
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. question Issues that look for answers. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

1 participant