Skip to content

Node 7.10.1 #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dy-dx opened this issue Jul 11, 2017 · 5 comments
Closed

Node 7.10.1 #456

dy-dx opened this issue Jul 11, 2017 · 5 comments

Comments

@dy-dx
Copy link

dy-dx commented Jul 11, 2017

Node 7.10 was removed from this repo when 8.0.0 was released (#411). The comments on that PR assumed 7 was a completely abandoned branch, but 7.10.1 was just released to fix a security vulnerability.
@dy-dx dy-dx mentioned this issue Jul 11, 2017
Merged
@SimenB
Copy link
Member

SimenB commented Jul 11, 2017

@nodejs/docker unsure how to handle this?

@chorrell
Copy link
Contributor

We'll need to add back the 7.10 directory and files and work on an update. Unfortunately #411 including dropping 7.10 when 8.0 was added in a single commit/PR. In the future we should avoid doing that and drop major versions in a separate PR. That being said, I think this kind of situation is rare and dropping 7.x at the time was a reasonable thing to do.

@chorrell
Copy link
Contributor

I'll try and get a PR for v7.10.1 going

@chorrell
Copy link
Contributor

See #458

@SimenB SimenB closed this as completed in 0fcdf0b Jul 11, 2017
SimenB added a commit that referenced this issue Jul 11, 2017
@SimenB
Merge pull request #458 from chorrell/v7.10.1
22d3787 
Update for Node.js v7.10.1. Fixes #456.
@dy-dx
Copy link
Author

dy-dx commented Jul 12, 2017

Thank you @chorrell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chorrell @dy-dx @SimenB