release 4.1.1 -> master #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up semver and update changelog for dev branch
Bumps [eslint](https://github.com./eslint/eslint) from 8.0.0 to 8.2.0. - [Release notes](https://github.com./eslint/eslint/releases) - [Changelog](https://github.com./eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.0.0...v8.2.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sinon](https://github.com./sinonjs/sinon) from 7.5.0 to 12.0.1. - [Release notes](https://github.com./sinonjs/sinon/releases) - [Changelog](https://github.com./sinonjs/sinon/blob/master/docs/changelog.md) - [Commits](sinonjs/sinon@v7.5.0...v12.0.1) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Moves all variables from `var` to either `let` or `const`
…-8.2.0 Bump eslint from 8.0.0 to 8.2.0
…12.0.1 Bump sinon from 7.5.0 to 12.0.1
Copied from DefinitelyTyped.
|
I will manually publish since it's a hotfix |
jankapunkt
reviewed
Nov 27, 2021
jankapunkt
approved these changes
Nov 27, 2021
There was a problem hiding this comment.
I give my approval with the disclaimer that I souppose you @HappyZombies know the TS types file is sufficient. I am no TS user yet.
The rest looks good / es expected.
If you still have doubts, you might choose another reviewer with focus on the TS files, I think you can also choose contributors, which are not necessarily members, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📖
This simple PR merges the changes from development into master.
View the CHANGELOG for what was added and changed.