Extend options stdlib #24849
Open
Extend options stdlib #24849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Apr 6, 2025
arnetheduck
reviewed
Apr 6, 2025
arnetheduck
reviewed
Apr 6, 2025
arnetheduck
reviewed
Apr 6, 2025
lib/pure/options.nim
Outdated
| assert some(-11).filterIt(it > 0) == none(int) | ||
| block: | ||
| var outcome: Option[T] | ||
| if value.isSome: |
There was a problem hiding this comment.
same here where value is instantiated multiple times - also, this implementation has the surprising and expensive implementation characteristic that when action returns true, the value is copied twice instead of not at all - compare that with seq that leaves its elements untouched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds more procs to the
optionsstdlib. These are convenience functions that make life easier when interacting with Options -- I've wound up adding them to just about every app I have written with Nim.