* Basic support for T-SQL query hints. #3008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
reviewed
Jan 30, 2022
| /// </summary> | ||
| /// <param name="hint">The t-sql query hint</param> | ||
| /// <returns><see langword="this" /> (for method chaining).</returns> | ||
| IQueryableOptions SetHint(string hint); |
There was a problem hiding this comment.
This interface should not be changed. It is obsolete.
hazzik
reviewed
Jan 30, 2022
| /// empty superclass implementation merely returns its first | ||
| /// argument. | ||
| /// </summary> | ||
| protected virtual SqlString ApplyHint(SqlString sql, string hints, Dialect.Dialect dialect) |
There was a problem hiding this comment.
This method is not used anywhere.
hazzik
reviewed
Jan 30, 2022
| @@ -343,9 +351,9 @@ protected override IResultTransformer ResolveResultTransformer(IResultTransforme | |||
| Object[] resultRow = GetResultRow(row, rs, session); | |||
| bool hasTransform = HasSelectNew || resultTransformer != null; | |||
| return (!hasTransform && resultRow.Length == 1 | |||
| ? resultRow[0] | |||
hazzik
reviewed
Jan 30, 2022
| @@ -441,7 +449,7 @@ internal IEnumerable GetEnumerable(QueryParameters queryParameters, IEventSource | |||
| var rs = GetResultSet(cmd, queryParameters, session, null); | |||
|
|
|||
| var resultTransformer = _selectNewTransformer ?? queryParameters.ResultTransformer; | |||
| IEnumerable result = | |||
| IEnumerable result = | |||
hazzik
reviewed
Jan 30, 2022
| @@ -62,5 +63,11 @@ public bool DefinesLimits | |||
| { | |||
| get { return maxRows != NoValue || firstRow > 0; } | |||
| } | |||
|
|
|||
| public string Hint | |||
There was a problem hiding this comment.
This is a strange place to add query hint...
There was a problem hiding this comment.
What would be a better place?
|
The PR is incomplete. The hints are set, but not used by anything. And it lacks tests. We cannot accept PRs without tests |
|
I'm going to close this PR as it is incomplete as far as I concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch a basic support for T-SQL query hints is provided. It is possible to use:
.WithOptions(u => u.SetHint("RECOMPILE"))