feat: unsafe updates for raw pointer arguments #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereferencing raw pointers is inherently unsafe. To satisfy clippy these functions and their callers require an unsafe indicator.
|
This changes the safety designation of some functions to satisfy clippy. Since this is a breaking change for consumers I'd like to discuss alternative approaches, but I couldn't find one in a timely manner. |
ivanitskiy
approved these changes
Jul 21, 2023
ivanitskiy
reviewed
Aug 25, 2023
| unsafe { | ||
| copy_nonoverlapping(data.as_ptr(), ptr, data.len()); | ||
| } | ||
| pub unsafe fn str_to_uchar(pool: *mut ngx_pool_t, data: &str) -> *mut u_char { |
There was a problem hiding this comment.
Since nginx-sys changed without backward compatibility, let's bump its version in nginx-sys/Cargo.toml
There was a problem hiding this comment.
this would require re-publishing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereferencing raw pointers is inherently unsafe. To satisfy clippy these functions and their callers require an unsafe indicator.
Checklist
Before creating a PR, run through this checklist and mark each as complete.