-
Notifications
You must be signed in to change notification settings - Fork 114
Add more unit tests for GRPCRoute #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just have a small comment
Problem: The change_processor tests were missing GRPCRoute cases. Solution: Add these test cases to improve coverage of GRPCRoutes.
3a8a514
to
3305c90
Compare
Problem: The change_processor tests were missing GRPCRoute cases. Solution: Add these test cases to improve coverage of GRPCRoutes.
Problem: The change_processor tests were missing GRPCRoute cases.
Solution: Add these test cases to improve coverage of GRPCRoutes.
Closes #2352
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.