Add support for large NGINX config file sizes #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
reviewed
Apr 22, 2025
| @@ -26,6 +29,107 @@ import ( | |||
| "github.com./stretchr/testify/require" | |||
| ) | |||
|
|
|||
| type FakeClientStreamingClient struct { | |||
There was a problem hiding this comment.
Can these fakes be put in a a file in the fakes directory ?
| fileName: filePath, | ||
| } | ||
|
|
||
| t.Logf("fakeServerStreamingClient: %v", fakeServerStreamingClient) |
There was a problem hiding this comment.
Was this log meant to be left in ?
| fakeServerStreamingClient.chunks[uint32(i)] = []byte{fileContent[i]} | ||
| } | ||
|
|
||
| t.Logf("fakeServerStreamingClient: %v", fakeServerStreamingClient) |
| fileManagerService := NewFileManagerService(fakeFileServiceClient, agentConfig) | ||
|
|
||
| request := protos.CreateConfigApplyRequest(overview) | ||
| t.Logf("request: %v", request) |
| @@ -30,6 +33,7 @@ import ( | |||
| "google.golang.org/protobuf/types/known/timestamppb" | |||
|
|
|||
| backoffHelpers "github.com./nginx/agent/v3/internal/backoff" | |||
| grpc2 "google.golang.org/grpc" | |||
There was a problem hiding this comment.
can we change the import name from grpc2 ?
| return nil | ||
| } | ||
|
|
||
| func (fms *FileManagerService) writeChunkedFile( |
There was a problem hiding this comment.
Should this be in file_operator.go ?
| return fms.getChunkedFile(ctx, file) | ||
| } | ||
|
|
||
| func (fms *FileManagerService) getFile(ctx context.Context, file *mpi.File) error { |
There was a problem hiding this comment.
Suggested change
| func (fms *FileManagerService) getFile(ctx context.Context, file *mpi.File) error { | |
| func (fms *FileManagerService) file(ctx context.Context, file *mpi.File) error { |
| return fms.validateFileHash(file.GetFileMeta().GetName()) | ||
| } | ||
|
|
||
| func (fms *FileManagerService) getChunkedFile(ctx context.Context, file *mpi.File) error { |
There was a problem hiding this comment.
Suggested change
| func (fms *FileManagerService) getChunkedFile(ctx context.Context, file *mpi.File) error { | |
| func (fms *FileManagerService) chunkedFile(ctx context.Context, file *mpi.File) error { |
aphralG
reviewed
Apr 22, 2025
| "context" | ||
| "encoding/json" | ||
| "errors" | ||
| "fmt" | ||
| "io" |
There was a problem hiding this comment.
This has nothing to do with this import just wondering if we could look at refactoring this file or look at the whole file plugin, operator and manager service or something. There is now a lot going on in this file and wondering if we could do something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for file chunking when uploading and downloading NGINX config from a management plane.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)