-
Notifications
You must be signed in to change notification settings - Fork 683
Add a documentation note about AWS_PROFILE #5931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
@christopher-hakkaart can you please review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. I've made a suggestion. Can you please check if the meaning is retained?
@christopher-hakkaart Yes, that suggested change looked fine. Let me know if you want me to squash the commits down and/or rebase to master. |
@Lenbok, your commit wasn't signed off. Can you rebase and sign it off? |
@christopher-hakkaart Should be good now. |
Hmmm, it looks like the sign-off is still missing. I'll check the logs. |
This environment variable is supported when accessing S3, so note that in the documentation. Signed-off-by: Len Trigg <[email protected]>
@christopher-hakkaart Sorry, I had crypto signed my commit, but it seems you're looking for the "signed-off" line in the commit message? (which seems kinda redundant in that case). |
This environment variable is supported when accessing S3, so note that in the documentation.