Skip to content

Add a documentation note about AWS_PROFILE #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lenbok
Copy link

@Lenbok Lenbok commented Mar 31, 2025

This environment variable is supported when accessing S3, so note that in the documentation.

@Lenbok Lenbok requested a review from a team as a code owner March 31, 2025 20:31
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 0a0748e
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/68017179b164720008fac9fb

@pditommaso
Copy link
Member

@christopher-hakkaart can you please review ?

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. I've made a suggestion. Can you please check if the meaning is retained?

@Lenbok
Copy link
Author

Lenbok commented Apr 16, 2025

@christopher-hakkaart Yes, that suggested change looked fine. Let me know if you want me to squash the commits down and/or rebase to master.

@christopher-hakkaart
Copy link
Collaborator

@Lenbok, your commit wasn't signed off. Can you rebase and sign it off?

@Lenbok
Copy link
Author

Lenbok commented Apr 16, 2025

@christopher-hakkaart Should be good now.

@christopher-hakkaart
Copy link
Collaborator

Hmmm, it looks like the sign-off is still missing. I'll check the logs.

This environment variable is supported when accessing S3, so note that in the documentation.

Signed-off-by: Len Trigg <[email protected]>
@Lenbok
Copy link
Author

Lenbok commented Apr 17, 2025

@christopher-hakkaart Sorry, I had crypto signed my commit, but it seems you're looking for the "signed-off" line in the commit message? (which seems kinda redundant in that case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants