Skip to content

Do not throw 500 HTTP error if no user is logged in #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2022

Conversation

christianlupus
Copy link
Collaborator

Just a small regression in the dependency injection code.

Closes #951

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #956 (c9eb914) into master (9d203c8) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   28.50%   28.95%   +0.45%     
==========================================
  Files          29       30       +1     
  Lines        1540     1547       +7     
==========================================
+ Hits          439      448       +9     
+ Misses       1101     1099       -2     
Flag Coverage Δ
integration 5.49% <0.00%> (-0.03%) ⬇️
unittests 23.46% <100.00%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Controller/MainController.php 100.00% <ø> (ø)
lib/Service/RecipeService.php 0.00% <ø> (ø)
lib/Exception/UserNotLoggedInException.php 100.00% <100.00%> (ø)
lib/Helper/UserConfigHelper.php 100.00% <100.00%> (ø)
lib/Exception/UserFolderNotWritableException.php 100.00% <0.00%> (+100.00%) ⬆️

@christianlupus christianlupus requested a review from seyfeb April 12, 2022 08:10
@github-actions
Copy link

Unit Test Results

     22 files       22 suites   8m 24s ⏱️
   120 tests    120 ✔️ 0 💤 0
1 320 runs  1 320 ✔️ 0 💤 0

Results for commit c9eb914.

Copy link
Collaborator

@seyfeb seyfeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seyfeb seyfeb merged commit 01a8c71 into master Apr 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/951-no-logged-in-user branch April 14, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in UserConfigHelper, when accessing cookbook URL, while not being logged in
2 participants