Skip to content

Fixed fix introduced to avoid empty category name #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

christianlupus
Copy link
Collaborator

In #805 a bug was introduced as trim was again called on a potential array. This should fix that.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #820 (2db71df) into master (032c904) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   21.30%   21.27%   -0.03%     
==========================================
  Files          20       20              
  Lines        1549     1551       +2     
==========================================
  Hits          330      330              
- Misses       1219     1221       +2     
Flag Coverage Δ
integration 7.09% <0.00%> (-0.01%) ⬇️
unittests 14.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Service/DbCacheService.php 0.00% <0.00%> (ø)

@github-actions
Copy link

github-actions bot commented Oct 18, 2021

Unit Test Results

  20 files    20 suites   7m 55s ⏱️
  66 tests   66 ✔️ 0 💤 0
660 runs  660 ✔️ 0 💤 0

Results for commit 2db71df.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus merged commit 5793701 into master Oct 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/trim-on-array branch October 18, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant