Skip to content

Deprecate some routes by comments #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Deprecate some routes by comments #580

merged 3 commits into from
Feb 23, 2021

Conversation

christianlupus
Copy link
Collaborator

We have still some old API endpoints that should be cleaned up. This PR should clean up no longer used routes and structure the code better.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #580 (c139e57) into master (eeb9e1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #580   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      444     444           
========================================
  Files            14      14           
  Lines          1385    1385           
========================================
  Hits             14      14           
  Misses         1371    1371           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/MainController.php 0.00% <ø> (ø) 40.00 <0.00> (ø)

@christianlupus
Copy link
Collaborator Author

@Teifun2 please look if you are using one of the Unknown usage endpoints. These might still work currently but if we are deciding to deprecate them (I assume so), this might cause issues for you. There are alternatives under the /api/recipes tree.

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review February 23, 2021 08:28
@christianlupus christianlupus merged commit 341f444 into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/cleanup-api branch February 23, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant