Renaming category

[seyfeb]

• added API endpoint ('url' => '/api/category/{category}', 'verb' => 'PUT')
• made categories in navigation pane editable

Closes #322

[codecov]

Codecov Report

Merging #555 (74f7608) into master (b42b21e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master    #555      +/-   ##
===========================================
- Coverage      1.02%   1.01%   -0.02%     
- Complexity      434     440       +6     
===========================================
  Files            13      13              
  Lines          1366    1381      +15     
===========================================
  Hits             14      14              
- Misses         1352    1367      +15     

Flag	Coverage Δ	Complexity Δ
integration	0.00% <0.00%> (ø)	0.00 <6.00> (ø)
unittests	1.01% <0.00%> (-0.02%)	0.00 <6.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/MainController.php	0.00% <0.00%> (ø)	39.00 <6.00> (+6.00)

[christianlupus]

I found an issue with the code changes when you change the name multiple times. Do you want to fix this before merging or want me to open a new issue afterward to keep things separated?

[christianlupus]

One more thing: ATM I have to reject the PR. We need to update the API minor version as we have some changes of the API endpoints.

[seyfeb]

I found an issue with the code changes when you change the name multiple times. Do you want to fix this before merging or want me to open a new issue afterward to keep things separated?

I did quite some changes since your comment. @christianlupus Does this still exist?

One more thing: ATM I have to reject the PR. We need to update the API minor version as we have some changes of the API endpoints.

Okay, we could also create a separate controller for categories.

[christianlupus]

I found an issue with the code changes when you change the name multiple times. Do you want to fix this before merging or want me to open a new issue afterward to keep things separated?

I did quite some changes since your comment. @christianlupus Does this still exist?

Not exactly the same but similar. As an image says more than 1000 words and a video has 25 images per sec, this is worth a whole book 😄:

vokoscreenNG-2021-01-25_08-47-30.mp4

One more thing: ATM I have to reject the PR. We need to update the API minor version as we have some changes of the API endpoints.

Okay, we could also create a separate controller for categories.

No, keeping that in the main controller is OK so far (no talked from a codebase refactoring perspective).
What I mean is the fact that 3rd part apps like the one from @Teifun2 use our API endpoints as REST service. To allow them to have a clear understanding, which cookbook app version is running, I introduced #487.
The cookbook version is incremented automatically by the bumping script but the API version must be handled manually. I just pushed a commit to update to API version 0.2.

[seyfeb]

Alright, this was really helpful. After updating some more stuff, I think this problem should be fixed and I was able to do some other improvements as well.

[GutHib]

Seems like you guys can read my thoughts. Nice addition - thank you.

[christianlupus]

I just had a look and it seems to work "mostly". I have one issue but it seems this is an upstream bug of the nextcloud-vue components: Open the edit field and try to move the cursor by clicking with the mouse. In my instance, this triggered the :to link to be navigated. If @seyfeb has no idea why this is happening, I think we can merge this PR. I will just rebase to get rid of the conflicts.

[seyfeb]

I just had a look and it seems to work "mostly". I have one issue but it seems this is an upstream bug of the nextcloud-vue components: Open the edit field and try to move the cursor by clicking with the mouse. In my instance, this triggered the :to link to be navigated. If @seyfeb has no idea why this is happening, I think we can merge this PR. I will just rebase to get rid of the conflicts.

We might want to consider updating the @nextcloud/vue dependency and see if this issue is gone. However this is quite a version jump so we need to carefully check the breaking changes of the versions in between.

[christianlupus]

I am going to merge this now and open an issue that might get closed once the problem is identified and solved.