Skip to content

Create a central class for parsing of AJAX parameters in POST/PUT #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 15, 2021

Conversation

christianlupus
Copy link
Collaborator

This should make implementing new endpoints simpler and reduces the probability of errors.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #518 (8fe4c57) into master (542fbc9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #518      +/-   ##
===========================================
- Coverage      0.90%   0.87%   -0.04%     
- Complexity      416     436      +20     
===========================================
  Files            13      14       +1     
  Lines          1319    1375      +56     
===========================================
  Hits             12      12              
- Misses         1307    1363      +56     
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 0.00 <23.00> (ø)
unittests 0.87% <0.00%> (-0.04%) 0.00 <23.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <0.00%> (ø) 7.00 <1.00> (ø)
lib/Controller/MainController.php 0.00% <0.00%> (ø) 33.00 <1.00> (ø)
lib/Controller/RecipeController.php 0.00% <0.00%> (ø) 14.00 <1.00> (ø)
lib/Helper/RestParameterParser.php 0.00% <0.00%> (ø) 20.00 <20.00> (?)

@christianlupus christianlupus merged commit 9de5f9c into master Jan 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/json-config branch January 15, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant