Skip to content

Allow access of guest accounts #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2021
Merged

Conversation

christianlupus
Copy link
Collaborator

If the user folder is not writable as typically for a guest account, the cookbook app has hight probability of being non-functional. Yet, there are no useful error messages or ways to tackle the problem. Instead a stacktrace is generated.

This should get this issue covered.

Closes #468

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #506 (f2a8edd) into master (a325d89) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #506      +/-   ##
===========================================
- Coverage      1.01%   1.01%   -0.01%     
- Complexity      440     444       +4     
===========================================
  Files            13      14       +1     
  Lines          1374    1385      +11     
===========================================
  Hits             14      14              
- Misses         1360    1371      +11     
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 0.00 <1.00> (ø)
unittests 1.01% <0.00%> (-0.01%) 0.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <0.00%> (ø) 7.00 <0.00> (ø)
lib/Controller/MainController.php 0.00% <0.00%> (ø) 40.00 <0.00> (+1.00)
lib/Exception/UserFolderNotWritableException.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
lib/Service/RecipeService.php 0.00% <0.00%> (ø) 239.00 <0.00> (+2.00)

@christianlupus christianlupus changed the title Allow acces of guest accounts Allow access of guest accounts Jan 12, 2021
@christianlupus
Copy link
Collaborator Author

It might be good to wait for #497 to be merged as this will simplify the frontend checks probably.

@christianlupus christianlupus force-pushed the fix/468-guest-accounts branch 2 times, most recently from bb15f5d to bdfed44 Compare February 12, 2021 12:09
@seyfeb
Copy link
Collaborator

seyfeb commented Feb 13, 2021

I just checked the functionality (not code) and noticed the following:

  • For a narrow window (either in height or width) the border is broken for the folder-selection page

Screenshot 2021-02-13 at 13 24 51

Screenshot 2021-02-13 at 13 25 09

  • Selecting a shared folder as a guest doesn’t work for me
    • The selection dialog is opened and it is possible to select the folder
    • After selection nothing happens and a 500 is logged

Screenshot 2021-02-13 at 13 28 35

Screenshot 2021-02-13 at 13 31 21

Screenshot 2021-02-13 at 14 44 48

@christianlupus christianlupus marked this pull request as ready for review February 14, 2021 12:24
@christianlupus christianlupus merged commit 6f4e4ce into master Feb 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/468-guest-accounts branch February 14, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes on loading if folder location cannot be accessed or created
2 participants