-
Notifications
You must be signed in to change notification settings - Fork 98
Allow access of guest accounts #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
===========================================
- Coverage 1.01% 1.01% -0.01%
- Complexity 440 444 +4
===========================================
Files 13 14 +1
Lines 1374 1385 +11
===========================================
Hits 14 14
- Misses 1360 1371 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It might be good to wait for #497 to be merged as this will simplify the frontend checks probably. |
bb15f5d
to
bdfed44
Compare
I just checked the functionality (not code) and noticed the following:
|
seyfeb
reviewed
Feb 13, 2021
seyfeb
reviewed
Feb 14, 2021
seyfeb
reviewed
Feb 14, 2021
seyfeb
reviewed
Feb 14, 2021
seyfeb
reviewed
Feb 14, 2021
5b83c72
to
54ff651
Compare
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Co-authored-by: seyfeb <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
54ff651
to
bc06846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user folder is not writable as typically for a guest account, the cookbook app has hight probability of being non-functional. Yet, there are no useful error messages or ways to tackle the problem. Instead a stacktrace is generated.
This should get this issue covered.
Closes #468