Skip to content

Create basic structure to allow automatic deployments #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2020

Conversation

christianlupus
Copy link
Collaborator

This PR should allow deployments to the NC app store using simple pushes to the stable branch.

Closes #233

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #433 (94c029c) into master (7dade4d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #433   +/-   ##
========================================
  Coverage      0.95%   0.95%           
  Complexity      401     401           
========================================
  Files            13      13           
  Lines          1262    1262           
========================================
  Hits             12      12           
  Misses         1250    1250           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 0.95% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator Author

@mrzapp I tried to use the REST API of the app store of NC. According to their policy, only maintainers and co-maintainers can upload new releases (in addition to the signature process using openssl). Currently, you are the only maintainer. All other people will get a 403 Forbidden answer upon release upload.
I see 2 options here:

  1. You provide a login token to your account of the NC app store as a secret in the repo (it is in your account settings under security)
  2. You add another co-maintainer to the app who's token can be used.

I am not able to proceed here any further with the main task but need to know what way we should go.

@mrzapp
Copy link
Contributor

mrzapp commented Dec 14, 2020

@christianlupus thanks for looking into this.

I was unable to find any way to add other accounts as co-maintainers, but I've provided an API token by the name "APP_STORE_TOKEN" in the repo secrets now

Squashed commit of the following:

commit a2b1b09
Merge: 7b83b4e a29b9e6
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:42:36 2020 +0000

    Merge branch 'test-stable' into test/deployment-tests

commit a29b9e6
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:42:36 2020 +0000

    Bump to version 1.1.1

    Signed-off-by: Github actions bot <[email protected]>

commit 121b0e4
Merge: 0745de8 7b83b4e
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:42:00 2020 +0100

    Merge remote-tracking branch 'upstream/test/deployment-tests' into test-stable

commit 7b83b4e
Merge: 0909dc2 0745de8
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:32:31 2020 +0000

    Merge branch 'test-stable' into test/deployment-tests

commit 0745de8
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:32:31 2020 +0000

    Bump to version 1.1.0

    Signed-off-by: Github actions bot <[email protected]>

commit f5aab0f
Merge: 77e6a9a 0909dc2
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:31:58 2020 +0100

    Merge remote-tracking branch 'upstream/test/deployment-tests' into test-stable
    %MINOR%

commit 0909dc2
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:31:21 2020 +0100

    Corrected typo in workflow file

    Signed-off-by: Christian Wolf <[email protected]>

commit 77e6a9a
Merge: ee95ddb cc9b768
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:29:00 2020 +0100

    Merge remote-tracking branch 'upstream/test/deployment-tests' into test-stable
    %MINOR%

commit cc9b768
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:28:23 2020 +0100

    Create a GH release in action

    Signed-off-by: Christian Wolf <[email protected]>

commit eb62ae9
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:28:12 2020 +0100

    Update the version update script to use the correct tag name

    Signed-off-by: Christian Wolf <[email protected]>

commit ee95ddb
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:17:49 2020 +0000

    Bump to version 1.0.0

    Signed-off-by: Github actions bot <[email protected]>

commit 4f3c70f
Merge: 34a13a4 ee95ddb
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:17:49 2020 +0000

    Merge branch 'test-stable' into test/deployment-tests

commit 85e4779
Merge: 83dbf4a 34a13a4
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:17:07 2020 +0100

    Merge remote-tracking branch 'upstream/test/deployment-tests' into test-stable
    %MAJOR%

commit 34a13a4
Merge: df7e29d 83dbf4a
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:16:30 2020 +0000

    Merge branch 'test-stable' into test/deployment-tests

commit 83dbf4a
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:16:30 2020 +0000

    Bump to version 0.8.0

    Signed-off-by: Github actions bot <[email protected]>

commit 82c8585
Merge: b3cf91a df7e29d
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:15:46 2020 +0100

    Merge remote-tracking branch 'upstream/test/deployment-tests' into test-stable
    %MINOR%

commit df7e29d
Merge: e61e18e b3cf91a
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:13:26 2020 +0000

    Merge branch 'test-stable' into test/deployment-tests

commit b3cf91a
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:13:26 2020 +0000

    Bump to version 0.7.9

    Signed-off-by: Github actions bot <[email protected]>

commit b1f2dd3
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:12:49 2020 +0100

    Merge update version back to master branch

    Signed-off-by: Christian Wolf <[email protected]>

commit 45c9f71
Author: Github actions bot <[email protected]>
Date:   Fri Dec 11 17:08:43 2020 +0000

    Bump to version 0.7.8

    Signed-off-by: Github actions bot <[email protected]>

commit e61e18e
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:06:57 2020 +0100

    Corrected workflow file syntax

    Signed-off-by: Christian Wolf <[email protected]>

commit 229d373
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:03:06 2020 +0100

    Turn on git updating using action script

    Signed-off-by: Christian Wolf <[email protected]>

commit a19d191
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:01:43 2020 +0100

    Run action only on stable branch

    Signed-off-by: Christian Wolf <[email protected]>

commit c5e92b7
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 18:01:28 2020 +0100

    Readd info.xml file as unitests need them

    Signed-off-by: Christian Wolf <[email protected]>

commit 03aef0f
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 17:51:26 2020 +0100

    Added debug commands to bumping script

    Signed-off-by: Christian Wolf <[email protected]>

commit a6ecf5e
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 17:42:01 2020 +0100

    Corrected ordering in version bumping commands

    Signed-off-by: Christian Wolf <[email protected]>

commit c867cc9
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 17:36:57 2020 +0100

    Add script for version bumping (with disabled pushing)

    Signed-off-by: Christian Wolf <[email protected]>

commit 14ad957
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 17:32:36 2020 +0100

    Create basic app information

    Signed-off-by: Christian Wolf <[email protected]>

commit c4faa6d
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 16:08:05 2020 +0100

    Corrected workflow syntax

    Signed-off-by: Christian Wolf <[email protected]>

commit c1e5f0a
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 16:04:21 2020 +0100

    Enable generation of tarball and signature of it

    Signed-off-by: Christian Wolf <[email protected]>

commit e1ce83e
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 15:54:41 2020 +0100

    Remove webpack config from tarball

    Signed-off-by: Christian Wolf <[email protected]>

commit fff324e
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 15:51:44 2020 +0100

    Corrected workflow syntax

    Signed-off-by: Christian Wolf <[email protected]>

commit 8620897
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 15:48:39 2020 +0100

    Basic structure is deploy workflow

    Signed-off-by: Christian Wolf <[email protected]>

commit eee89f5
Author: Christian Wolf <[email protected]>
Date:   Fri Dec 11 15:48:12 2020 +0100

    Update the makefile to allow a non-dev installation from composer

    Signed-off-by: Christian Wolf <[email protected]>

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review December 20, 2020 14:57
@christianlupus
Copy link
Collaborator Author

As I cannot test the syntax without actually doing the release, I will have to hope for the best and give the PR a try. If it does not work, I will have to fix the issues starting from there.

@christianlupus christianlupus merged commit 69176d6 into master Dec 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the dev/deployment branch December 20, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic deployment
2 participants