Added multiselection for categories and keywords to recipe editor #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyfeb
force-pushed
the
feature/addedMultiselectToRecipeEdit
branch
from
272457c to
2aecbec
Compare
|
@sam-19 Could you have a look at this? This PR touches only frontend parts. |
christianlupus
approved these changes
Dec 6, 2020
|
This is a good change. I don't have time to properly test it in a dev setting, but don't see anything apparently wrong with the changes. See my comment about using an implicit value prop in #386. |
seyfeb
force-pushed
the
feature/addedMultiselectToRecipeEdit
branch
from
2aecbec to
aeed020
Compare
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage 0.92% 0.92%
Complexity 410 410
========================================
Files 13 13
Lines 1300 1300
========================================
Hits 12 12
Misses 1288 1288
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
… Added fallback in case loading kws or categories fails Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
christianlupus
force-pushed
the
feature/addedMultiselectToRecipeEdit
branch
from
aeed020 to
9934bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a NC-styled
Multiselectelement for keywords and categories for faster insertion.There is some collision with PR #386 but only for the keyword and category selection, which should be replaced by this one if accepted.
Closes #313 although for the future we might want to consider adding something similar for selecting ingredients, keywords, and tools as mentioned in the issue