Skip to content

Fix default recipe image fallback to be a valid value: "full" #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saywebsolutions
Copy link
Contributor

Topic and Scope

Fixes issue #1453 and allows the image endpoint to default to returning the full image if no size param is specified.

Concerns/issues

Alternatively the thumb size could be used if it's preferred to default to that instead of full.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus christianlupus force-pushed the image-endpoint-default-size branch from d541358 to 752bb68 Compare March 6, 2025 15:53
Copy link

github-actions bot commented Mar 6, 2025

Test Results

   12 files    588 suites   1m 56s ⏱️
  577 tests   577 ✅ 0 💤 0 ❌
2 308 runs  2 307 ✅ 1 💤 0 ❌

Results for commit b9d25ab.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus enabled auto-merge March 6, 2025 19:42
@christianlupus christianlupus merged commit c5d874b into nextcloud:master Mar 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image API endpoint returns the fallback image when no size is specified
2 participants