Skip to content

fix: replace --delete-delay by --delete-before to work on macos #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timdreier
Copy link
Contributor

Topic and Scope

This PR fixes #2441. It replaces the --delete-delay of rsync by --delete-before, because --delete-delay isn't implemented in rsync on macOS.

Concerns/issues

The flag --delete-before deletes removed files before copying the changed files. In this scenario the change of this flag shouldn't make any difference.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus christianlupus force-pushed the 2441-fix-automated-tests-mac branch from 71d562f to 439122f Compare October 26, 2024 07:57
Signed-off-by: Christian Wolf <[email protected]>
Copy link

Test Results

    9 files    438 suites   1m 16s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
1 725 runs  1 724 ✅ 1 💤 0 ❌

Results for commit 439122f.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit bf32c41 into nextcloud:master Oct 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix automated test scripts for Mac users
2 participants