Skip to content

Add primary keys to all tables #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

timdreier
Copy link
Contributor

Topic and Scope

The PR adds primary keys to all tables to fix #2531 and #1984.

Concerns/issues

Shouldn't have any impact.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@timdreier timdreier marked this pull request as ready for review October 10, 2024 20:50
@timdreier timdreier changed the title Primary keys Add primary keys to all tables Oct 10, 2024
timdreier and others added 3 commits March 5, 2025 13:16
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Copy link

github-actions bot commented Mar 5, 2025

Test Results

   12 files    588 suites   1m 57s ⏱️
  576 tests   576 ✅ 0 💤 0 ❌
2 304 runs  2 303 ✅ 1 💤 0 ❌

Results for commit 8141ea7.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus enabled auto-merge March 5, 2025 13:03
@christianlupus christianlupus merged commit 7dcc1a1 into nextcloud:master Mar 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookbook_names table has no primary key
2 participants