Skip to content

fix: openapi specification #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Apr 7, 2024

Topic and Scope

int is not a valid openapi type so automated tools fail parsing the spec

Concerns/issues

N.A.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Nikolas Rimikis <[email protected]>
@Leptopoda Leptopoda requested a review from christianlupus April 7, 2024 12:51
Copy link

github-actions bot commented Apr 7, 2024

Test Results

   12 files    572 suites   1m 30s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit 1f512ba.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit 0380002 into nextcloud:master Apr 28, 2024
18 checks passed
@Leptopoda Leptopoda deleted the fix/spec branch April 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants