Skip to content

Chore/add typescript support #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Chore/add typescript support #2059

merged 4 commits into from
Jan 16, 2024

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Jan 14, 2024

Topic and Scope

Added support for typescript

Closes #2053

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@seyfeb seyfeb added javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9e8c6ac) 80.07% compared to head (b5318b8) 80.07%.
Report is 1 commits behind head on master.

❗ Current head b5318b8 differs from pull request most recent head 4d5a5bc. Consider uploading reports for the commit 4d5a5bc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          92       92           
  Lines        2650     2650           
=======================================
  Hits         2122     2122           
  Misses        528      528           
Flag Coverage Δ
integration 21.43% <22.22%> (ø)
migration 5.69% <22.22%> (ø)
unittests 57.09% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/Helper/AcceptHeaderParsingHelper.php 100.00% <100.00%> (ø)
lib/Helper/DownloadHelper.php 91.11% <100.00%> (ø)
lib/Helper/Filter/JSON/CleanCategoryFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixInstructionsFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixKeywordsFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/RecipeIdCopyFilter.php 100.00% <100.00%> (ø)
lib/Helper/HTMLParser/HttpJsonLdParser.php 100.00% <100.00%> (ø)
lib/Helper/HtmlToDomParser.php 95.31% <100.00%> (ø)
lib/Helper/UserFolderHelper.php 100.00% <100.00%> (ø)
lib/Migration/Version000000Date20210427082010.php 100.00% <100.00%> (ø)
... and 4 more

Copy link

github-actions bot commented Jan 14, 2024

Test Results

   12 files    572 suites   1m 30s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit b5318b8.

♻️ This comment has been updated with latest results.

@seyfeb seyfeb requested a review from christianlupus January 14, 2024 12:12
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see many changes except for stylistic ones (which do not count).

Please check that it is working, eventually fix the comments you mentioned and you can merge this.

Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb force-pushed the chore/add-typescript-support branch from b5318b8 to 4d5a5bc Compare January 16, 2024 12:56
@seyfeb seyfeb enabled auto-merge January 16, 2024 13:02
@seyfeb seyfeb merged commit 0871511 into master Jan 16, 2024
@seyfeb seyfeb deleted the chore/add-typescript-support branch January 16, 2024 13:04
@christianlupus
Copy link
Collaborator

@seyfeb Does it make sense to backport this to the main-0.10.x branch?

@seyfeb
Copy link
Collaborator Author

seyfeb commented Jan 26, 2024

Probably yes. I guess much of new frontend code could/should use typescript while existing code may be refactored into typescript. So if we want to continue to backport things the 0.10.x branch should have ts support, too.

@christianlupus christianlupus added the manual-backport-required The backpoort needs to be carried out manually. label Jan 26, 2024
@christianlupus christianlupus removed the manual-backport-required The backpoort needs to be carried out manually. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript support
2 participants