-
Notifications
You must be signed in to change notification settings - Fork 98
Chore/add typescript support #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2059 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 92 92
Lines 2650 2650
=======================================
Hits 2122 2122
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Test Results 12 files 572 suites 1m 30s ⏱️ Results for commit b5318b8. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see many changes except for stylistic ones (which do not count).
Please check that it is working, eventually fix the comments you mentioned and you can merge this.
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
b5318b8
to
4d5a5bc
Compare
@seyfeb Does it make sense to backport this to the main-0.10.x branch? |
Probably yes. I guess much of new frontend code could/should use typescript while existing code may be refactored into typescript. So if we want to continue to backport things the 0.10.x branch should have ts support, too. |
Topic and Scope
Added support for typescript
Closes #2053
Concerns/issues
None
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.