-
Notifications
You must be signed in to change notification settings - Fork 98
Refactor/rework recipe list filter #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2037 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 92 92
Lines 2650 2650
=======================================
Hits 2122 2122
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 12 files 572 suites 1m 31s ⏱️ Results for commit 7ea8520. ♻️ This comment has been updated with latest results. |
febd21d
to
a66e2e6
Compare
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…f recipes Signed-off-by: Sebastian Fey <[email protected]>
a6b2008
to
7ea8520
Compare
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…name filters. Support arrays in name filter Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…ers export Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…value is not defined on recipe Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…KeywordsFilter` can handle this now. Also add tests for this. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Sebastian Fey <[email protected]>
…t to OR for categories filter. Update tests. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
…ory and keywords selection displaying no. of selected items Signed-off-by: Sebastian Fey <[email protected]>
…isplaying no. of selected items Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
… keyword filter. Add AND/OR operator selectors for keywords and categories to inline filter controls Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
… selection modal. Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
… setting to display sorting and filters Signed-off-by: Sebastian Fey <[email protected]>
…settings Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
7ea8520
to
3d73d73
Compare
Topic and Scope
Considering issues like #253, which request more options for filtering recipes by different properties, the large keyword cloud does not seem to provide the best UI when mixed with additional ways to filter along different vectors. To create a more unified and extensible filter experience I reworked the current UX.
The new UI
The categories filter is only shown, when no category is selected.
Caveats, features and other noteworthy changes
name
,keywords
, andrecipeCategory
both single string and an array of strings is supported, even though the cookbook app currently only supports a single name and category.OR
filtering for categories therefore currently makes not too much sensefuse.js
libraryImpressions
Mobile devices
Desktop
cookbook_new_filter.mov
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.