Skip to content

Fix/1964 recipe search is not working #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix/1964 recipe search is not working #1965

merged 3 commits into from
Dec 13, 2023

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 12, 2023 •
edited by christianlupus
Loading

Topic and Scope

The search function was not working. Should be working again.

Closes #1964

Concerns/issues

Based on #1950 . The other PR should be merged first.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Depends on #1950

@seyfeb seyfeb added javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Dec 12, 2023
@github-actions GitHub Actions
Copy link

Test Results

552 tests   552 ✔️  19s ⏱️
143 suites      0 💤
    3 files        0 ❌

Results for commit f9d3950.

@christianlupus
Copy link
Collaborator

Attention, this is based on the other PR #1950. So, do not merge yet but first handle the other PR.

@christianlupus christianlupus added this to the Release 0.11.0 milestone Dec 12, 2023
@seyfeb seyfeb mentioned this pull request Dec 12, 2023
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

seyfeb and others added 3 commits December 13, 2023 08:42
@seyfeb @christianlupus
fix: Use correct string of search input for search URL
ea0535e 
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@seyfeb @christianlupus
fix: Update filter and search icons. Add aria-labels
4764522 
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Update Changelog
78faadb 
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus force-pushed the fix/1964-recipe-search-is-not-working branch from f9d3950 to 78faadb Compare December 13, 2023 07:44
@christianlupus christianlupus merged commit c7dfbf8 into master Dec 13, 2023
@christianlupus christianlupus deleted the fix/1964-recipe-search-is-not-working branch December 13, 2023 07:47
@christianlupus christianlupus mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianlupus christianlupus christianlupus approved these changes

Assignees
No one assigned
Labels
Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code
Projects
None yet
Milestone
Release 0.11.0
Development

Successfully merging this pull request may close these issues.

Recipe search is not working
2 participants
@seyfeb @christianlupus