Skip to content

Fix/1543 create filter to canonicalize time stamps #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Nov 28, 2023

Topic and Scope

Unifies the timestamps returned from the API by adding a filter for the timestamps.

Closes #1543

Concerns/issues

Assumes that the timestamps are already in the ISO8601 format (which is required by the schema.org standard anyway). If we decide to support more datetime formats this may be easily extended.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Copy link

github-actions bot commented Nov 28, 2023

Test Results

     27 files  1 287 suites   5m 26s ⏱️
   552 tests    552 ✔️ 0 💤 0
4 968 runs  4 967 ✔️ 1 💤 0

Results for commit 87cae41.

♻️ This comment has been updated with latest results.

@seyfeb seyfeb force-pushed the fix/1543-create-filter-to-canonicalize-time-stamps branch 2 times, most recently from 9b3b2a5 to 934b166 Compare November 28, 2023 08:00
seyfeb and others added 4 commits December 4, 2023 08:41
…for timestamp conversion.

Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus force-pushed the fix/1543-create-filter-to-canonicalize-time-stamps branch from 934b166 to 87cae41 Compare December 4, 2023 07:46
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianlupus christianlupus merged commit 4689458 into nextcloud:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create filter to canonicalize time stamps
2 participants