Skip to content

Feat/add empty content view #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Oct 29, 2023

Topic and Scope

Adds some info for empty cookbooks (no recipes) for, e.g., first-time users on how to get started.

Screenshot 2023-10-29 at 20 58 07

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

…er settings or an empty cookbook.

Closes nextcloud#1865.

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb added javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Oct 29, 2023
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb force-pushed the feat/add-empty-content-view branch from c413e36 to 2f6ef2d Compare October 29, 2023 20:36
@seyfeb
Copy link
Collaborator Author

seyfeb commented Oct 29, 2023

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

Test Results

     27 files  1 242 suites   7m 22s ⏱️
   501 tests    501 ✔️ 0 💤 0
4 509 runs  4 508 ✔️ 1 💤 0

Results for commit 2f6ef2d.

@seyfeb seyfeb merged commit 5f937ae into nextcloud:master Oct 29, 2023
@seyfeb seyfeb deleted the feat/add-empty-content-view branch October 29, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants