Skip to content

Make the different API endpoints for Recipe and RecipeStub more consistent #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

Closes #1827

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus added this to the Release 0.10.3 milestone Oct 9, 2023
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus
Copy link
Collaborator Author

/approve

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1834 (bda4050) into master (410d589) will increase coverage by 0.18%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1834      +/-   ##
==========================================
+ Coverage   79.48%   79.67%   +0.18%     
==========================================
  Files          87       89       +2     
  Lines        2559     2573      +14     
==========================================
+ Hits         2034     2050      +16     
+ Misses        525      523       -2     
Flag Coverage Δ
integration 21.88% <100.00%> (+0.66%) ⬆️
migration 5.86% <0.00%> (-0.04%) ⬇️
unittests 56.00% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/Helper/Filter/JSON/RecipeIdCopyFilter.php 100.00% <100.00%> (ø)
lib/Helper/Filter/RecipeStubFilter.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@christianlupus christianlupus merged commit 85f84c8 into master Oct 9, 2023
@christianlupus christianlupus deleted the fix/api-changes branch October 9, 2023 22:32
lneugebauer added a commit to lneugebauer/nextcloud-cookbook that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix recipe stub identifier
2 participants