-
Notifications
You must be signed in to change notification settings - Fork 98
Add yield calculator #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yield calculator #1573
Conversation
With respect to the translation issue, you are referring to the warning message, am I right? In general, you simply use something like
The important part is that everything is on one line (a bug in the implementation of the translation script). Make sure this in interpreted as JS code (so, it must be in a Could you please (before things gets overly complicated) amend the latest commit and sign off? This will avoid the DCO test to fail. |
Signed-off-by: Johannes Roth <[email protected]>
@christianlupus I've added the translation, but I'm not sure if I signed-off correctly. I did not edit the changelog, too. |
@christianlupus the pipeline fails because of code style. If I rund the command Should I edit the changelog? |
I can tell you that you signed off correctly. Otherwise, the DCO check would fail. Regarding the failing prettier test, one has to disable the rule for this single line. See for an example in the code: cookbook/src/components/RecipeView.vue Lines 22 to 23 in a809334
|
Signed-off-by: Johannes Roth <[email protected]>
@christianlupus ok, codestyle should be fixed. What about the changelog? |
Just add an entry to the added section (create one if needed) in the CHANGELOG.md file. That should do it. |
Signed-off-by: Johannes Roth <[email protected]>
Signed-off-by: Johannes Roth <[email protected]>
Signed-off-by: j0hannesr0th <[email protected]>
@christianlupus all checks ran successful now. Can you test and merge it please that no merge conflicts must be resolved again? Thanks! |
I already had a quick glance. I wanted to test manually a few more cases and did find one minor thing so far. Will fix and merge or come back to you. |
I just checked a few additional cases. Now, I found a few issues, that might come up in the close future (or to help enhance the code base). I will nevertheless approve/merge this PR to get the functionality into the app. The fixes can then be applied step by step. I will open a new bug with all found issues in order to tackle them. |
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
With which version will this be released? |
This should be in the next release 0.10.3. |
This pull request adds a client-side yield calculator to the recipe detail page of every recipe and fixes #116
@christianlupus I wasn't able to find "how to add translations" in the docu. It's my first contribution to a Nextcloud project and I only found a link to transifex. Can you assist/guide me here please?
The function (without translation) is ready:

Screenshots of the mobile version:
