Skip to content

Bump actions/setup-node from 2 to 3 #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ jobs:
- name: Checkout the project
uses: actions/checkout@v2
- name: Setup node and NPM
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- name: Install npm
shell: bash
run: npm install -g npm@^7
run: npm install -g npm@^8

- name: Get the date
id: date
Expand Down Expand Up @@ -348,12 +348,12 @@ jobs:
- name: Checkout the app
uses: actions/checkout@v2
- name: Setup node and NPM
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '14'
node-version: '16'
- name: Install npm
shell: bash
run: npm install -g npm@^7
run: npm install -g npm@^8

- name: Get the date
id: date
Expand All @@ -378,10 +378,6 @@ jobs:
${{ runner.os }}-composer-${{ steps.date.outputs.date }}-
${{ runner.os }}-composer-

- name: Update NPM
shell: bash
run: sudo npm install -g npm

- name: Install the NPM dependencies
shell: bash
run: >-
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
- Remove deprecated `::v-deep` CSS syntax @christianlupus
- Disable webpack bundle analyzer plugin by default to speed up development cycle
[#1263](https://github.com./nextcloud/cookbook/pull/1263) @MarcelRobitaille
- Update github actions
[1269](https://github.com./nextcloud/cookbook/pull/1269)

### Documentation
- Fix bad writing
Expand Down