Add timer alarm sound #1120
Merged
Add timer alarm sound #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRobitaille
force-pushed
the
671-timer-alarm-sound
branch
from
fedc186 to
24e9870
Compare
Signed-off-by: Marcel Robitaille <[email protected]>
After fixing the app name, we no longer need this hacky string replace when using file-loader Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
This is the new recommended method in webpack 5 https://webpack.js.org/guides/asset-modules/ Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
Signed-off-by: Marcel Robitaille <[email protected]>
If it's paused midway, by default it will resume from that point Signed-off-by: Marcel Robitaille <[email protected]>
MarcelRobitaille
force-pushed
the
671-timer-alarm-sound
branch
from
09a7447 to
103b812
Compare
|
I suppose this is mainly ready for review, right? If not, please remove the milestone. |
|
@christianlupus Yes, I think it's ready for review. Sorry, I'll use the draft features in the future or ping you to better indicate when it's ready. I'm fine if we merge this as is. I wasn't sure if you wanted to wait for #1067 so we could add the proposed user settings. |
Signed-off-by: Marcel Robitaille <[email protected]>
The app can be installed in arbitrary folders (like /custom_apps). This will break when the URL is hardcoded. This fix should make the URL dynamic with the NC core JS functions. Signed-off-by: Christian Wolf <[email protected]> # Conflicts: # src/components/RecipeTimer.vue
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671