Skip to content

Corrected default values in exception constructors #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

christianlupus
Copy link
Collaborator

Closes #1096

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1113 (c980c64) into master (9ee4154) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files          73       73           
  Lines        2292     2292           
=======================================
  Hits         1327     1327           
  Misses        965      965           
Flag Coverage Δ
integration 1.96% <6.66%> (ø)
migration 4.05% <0.00%> (ø)
unittests 51.87% <73.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Exception/ImportException.php 0.00% <0.00%> (ø)
lib/Exception/InvalidJSONFileException.php 0.00% <0.00%> (ø)
lib/Exception/RecipeExistsException.php 0.00% <0.00%> (ø)
lib/Exception/CouldNotGuessEncodingException.php 100.00% <100.00%> (ø)
lib/Exception/HtmlParsingException.php 100.00% <100.00%> (ø)
lib/Exception/InvalidDurationException.php 100.00% <100.00%> (ø)
lib/Exception/InvalidRecipeException.php 100.00% <100.00%> (ø)
lib/Exception/InvalidThumbnailTypeException.php 100.00% <100.00%> (ø)
lib/Exception/NoDownloadWasCarriedOutException.php 100.00% <100.00%> (ø)
lib/Exception/NoRecipeImageFoundException.php 100.00% <100.00%> (ø)
... and 5 more

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

Unit Test Results

     36 files       36 suites   10m 6s ⏱️
   403 tests    403 ✔️ 0 💤 0
4 836 runs  4 836 ✔️ 0 💤 0

Results for commit c980c64.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus marked this pull request as draft July 26, 2022 08:50
@christianlupus christianlupus added this to the Release 0.9.14 milestone Jul 26, 2022
@christianlupus christianlupus self-assigned this Jul 28, 2022
@christianlupus
Copy link
Collaborator Author

Superseded by #1137

@christianlupus christianlupus deleted the fix/exception-parameter-types branch August 4, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default types for exceptions
1 participant