Add a helper class to manage the user folders #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
…rk again Signed-off-by: Christian Wolf <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 40.65% 42.13% +1.47%
==========================================
Files 42 44 +2
Lines 1852 1875 +23
==========================================
+ Hits 753 790 +37
+ Misses 1099 1085 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
force-pushed
the
fix/1004-user-folder-helper
branch
from
c40bc07 to
2fe4698
Compare
|
@seyfeb The fixupbot seems to be broken at the moment. If you would confirm/approve the PR, I will force-merge it. |
…der-helper Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1004
This is a cherry-pick (plus modifications) from another dev branch to bring the functionality of a dedicated user folder helper class to the master branch. The class has some caching included to prevent unneeded calls to the DB.
This makes roughly 20% of the query time of fetching all recipes currently:
