Skip to content

Migrate from tslint to eslint #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2020
Merged

Migrate from tslint to eslint #161

merged 3 commits into from
Jan 26, 2020

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Jan 18, 2020

Description

This PR migrates the starter project from tslint to eslint. We don't have to follow/extend any external style guide (e.g. Airbnb), TypeScript defaults (and recommendations) seems to be in line with the framework best practices.

@kamilmysliwiec kamilmysliwiec changed the title deps(): migrate from tslint to eslint Migrate from tslint to eslint Jan 18, 2020
@kamilmysliwiec kamilmysliwiec merged commit 6e06f62 into master Jan 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/tslint-to-eslint branch January 26, 2020 11:25
@nechar
Copy link

nechar commented Feb 28, 2020

Thanks, @kamilmysliwiec for the update.

Just felt that it was worth mentioning to the community for devs who have an existing application containing TSLint.

Problem:
It was extremely difficult to get the configuration right when trying to upgrade manually (by uninstalling TSLint and then installing ESLint)

Solution:
Using the latest NestJS CLI v 6.14.2 (as of 28 Feb 2020), I was able to get the correct ESLint configuration and the compatible plugins that worked perfectly the nest application. (By creating a new NestJS application nest new app-name)
After that, all you need to do is

  • copy the new .eslint.js file and paste into your existing NestJS application.
  • delete the existing .tslint.json file
  • install the related ESLint packages that are listed in package.json into your existing NestJS application. (There are several of them)
  • uninstall TSLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants